added module for monitoring transmission-daemon via rpc #15
Conversation
|
Ha, this is nice. There is already a pull request for this but I guess yours is fully working and might be best. |
|
throw the transmissionrpc folder inside the external folder and it will work without installing transmissionrpc |
|
Don't worry this should be done with the merge. The problem is that master is not yet independent so it does not have the structure yet, but the next thing to go to master will definitely be the independent libraries. |
|
Any chance you can update this and fix any conflicts? |
|
I have tested this patch-set against latest mrkipling/maraschino@master and can confirm it applies cleanly. Can you handle the transmissionrpc module inclusion after the merge as there currently is no defined structure for independent libraries. |
|
We can but if you have the chance to do this before we get the chance to merge it would be great. If you want to have a look at the structure, just see either the experimental branch here or pull request #32. Are you sure it merges cleanly? Git says it doesn't and I'm pretty sure I had to modify a couple of (minor) things to get it going properly but I also merged other branches before (on the experimental branch) so it might have happened from other merges. This is already included in there as well as all open pull reuqests btw. |
|
I've made adjustments as per your recommendations - commit dff020e is ready for integration, it has been merged successfully with master@latest and tests OK. |
note(s):
- transmissionrpc 0.8 included in lib/transmissionrpc.
- marachino.py now sources libaries from lib/* using code snatched
from current experimental branch.
|
... marco ... ? |
|
polo... |
|
All clear for integration? Sent from my phone On 14/01/2012, at 7:57 PM, Gustavo [email protected] wrote:
|
|
Think so. As far as my tests went, all is good but @mrkipling is the one to make the merge tho and he's been sick the last few days and quite busy before that. |
|
Sorry this took so long to review - I've just merged it in. I don't use Transmission myself and haven't tested it thoroughly, but looking at the code it seems straight-forward enough (and gugahoi has informed me that it worked nicely for him). I'll hand it over to Transmission users on the XBMC forums to test. Thanks for the contribution! |
|
ghuntley, i had a problem where the module would vanish while a torrent was initialising. refer #69. i was unable to get the total eta to work after this 'fix' any chance you could take a look? |
|
Sure. I'm on holidays, when I get back (2 weeks) I can have a stab at it Sent from my phone On 09/02/2012, at 7:09 PM, David [email protected] wrote:
|
note: this commit is dependant on transmissionrpc, documentation will
need to be updated to reflect installation, etc.