added setting to open apps in new tab #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is good, however I think maybe a "per app" setting might fit in better? What do you guys think? We can have it set as the default behaviour and if there is a specific app or link a user wants to open in the current window then it can be unselected. Although I do think we should rethink how the applications module really works. |
|
Honestly, i dont even use the apps module. This only took a couple of minutes to knock up and fulfilled the request. |
|
fair enough, I'll merge it in as it is simple enough but I do think an upgrade is overdue for it... |
|
ah, I forgot to mention but you can refer to issues pretty easily. Just type: #141 |
|
ahh, cheers.. |
gugahoi
added a commit
that referenced
this pull request
May 28, 2012
added setting to open apps in new tab
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested here: #141