Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm_ls still failing when no values.yml exist #48

Closed
johannes-engler-mw opened this issue Oct 31, 2023 · 1 comment · Fixed by #49
Closed

Helm_ls still failing when no values.yml exist #48

johannes-engler-mw opened this issue Oct 31, 2023 · 1 comment · Fixed by #49

Comments

@johannes-engler-mw
Copy link

johannes-engler-mw commented Oct 31, 2023

Hello there,

we are deploying Helm charts via ArgoCD, so there is no values.yml below the template folder needed. While the change in #43 should fix that, it still fails for me on MacOS with ARM:

[START][2023-10-31 12:13:41] LSP logging initiated
[ERROR][2023-10-31 12:13:41] .../vim/lsp/rpc.lua:734    "rpc"   "/Users/johannes.e/.local/share/nvim/mason/bin/helm_ls"   "stderr" '{"level":"info","msg":"helm-lint-langserver: connections opened","time":"2023-10-31T12:13:41+01:00"}\n{"level":"info","msg":"Error loading values.yaml file open /Users/johannes.e/repos/deployment/applications/services/values.yml: no such file or directory","time":"2023-10-31T12:13:41+01:00"}\n'
[ERROR][2023-10-31 12:13:41] .../vim/lsp/rpc.lua:734    "rpc"   "/Users/johannes.e/.local/share/nvim/mason/bin/helm_ls"   "stderr" 'panic: request "initialize" was never replied to\n\ngoroutine 36 [running]:\n'
[ERROR][2023-10-31 12:13:41] .../vim/lsp/rpc.lua:734    "rpc"   "/Users/johannes.e/.local/share/nvim/mason/bin/helm_ls"   "stderr" "go.lsp.dev/jsonrpc2.ReplyHandler.func1({0x10416ea58, 0x140000420e8}, 0x140004b7300, {0x12c62c858?, 0x14000428b80?})\n\tgo.lsp.dev/[email protected]/handler.go:44 +0x158\ngo.lsp.dev/jsonrpc2.(*conn).run(0x140004a9a40, {0x10416ea58, 0x140000420e8}, 0x140004b9d10)\n\tgo.lsp.dev/[email protected]/conn.go:206 +0x234\ncreated by go.lsp.dev/jsonrpc2.(*conn).Go\n\tgo.lsp.dev/[email protected]/conn.go:189 +0xac\n"

Neovim only shows: Client 2 quit with exit code 2 and signal 0.

Mason installed the latest version:

/Users/johannes.e/.local/share/nvim/mason/bin/helm_ls version
HelmLs version: e534e0e
Build type: Nightly
Build time: 2023-09-30_12:30:33PM
Golang: go1.20.6
Compiled by: fv-az407-100

When I create an empty values.yml it works.

Can this be fixed?

BR,

Johannes

@qvalentin
Copy link
Collaborator

Sorry, my bad: Should have tested it better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants