Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PWR-ICE framing #313

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Fix PWR-ICE framing #313

merged 1 commit into from
Jan 24, 2022

Conversation

mrene
Copy link
Owner

@mrene mrene commented Jan 23, 2022

Adds a heuristic-based packet size detection in order to tolerate the PWR-ICE which use 70 bytes frames instead of 64.

refs #245

@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 250806e
Status: ✅  Deploy successful!
Preview URL: https://2361fdc1.minidsp-rs.pages.dev

View logs

@m-diers
Copy link

m-diers commented Jan 24, 2022

Verified:

#> ./target/release/minidsp --verbose probe --net
Probing for network devices...
Found: tcp:https://192.168.178.120:5333?name=PWR-ICE2%20%20%20%20%20%20%20%00

#> ./target/release/minidsp --tcp 192.168.178.120 probe
Found Generic with serial 900182 at tcp:https://192.168.178.120:5333 [hw_id: 0, dsp_version: 51]

#> ./target/release/minidsp --tcp 192.168.178.120
MasterStatus { preset: 0, source: NotInstalled, volume: Gain(-0.0), mute: false, dirac: false }
Input levels: 
Output levels:

#> ./target/release/minidsp --verbose --tcp 192.168.178.120
Sent: [31]
Sent: ReadHardwareId 
Recv: [31, 03, 00]
Recv: HardwareId { payload: [03, 00] }
Sent: [05, ff, a1, 01]
Sent: ReadMemory { addr: ffa1, size: 01 } 
Recv: [05, ff, a1, 33]
Recv: MemoryData(MemoryView { base: ffa1, data: [33] })
Sent: [05, ff, fe, 02]
Sent: ReadMemory { addr: fffe, size: 02 } 
Recv: [05, ff, fe, 00, b6]
Recv: MemoryData(MemoryView { base: fffe, data: [00, b6] })
Sent: [05, ff, d8, 09]
Sent: ReadMemory { addr: ffd8, size: 09 } 
Recv: [05, ff, d8, 00, 00, 00, 0MasterStatus { preset: 0, source: NotInstalled, volume: Gain(-0.0), mute: false, dirac: false }
Input levels: 
Output levels: 
0
, 00, 0a, 00, 37, 01]
Recv: MemoryData(MemoryView { base: ffd8, data: [00, 00, 00, 00, 00, 0a, 00, 37, 01] })

@mrene mrene merged commit e4ab2f9 into dev Jan 24, 2022
@mrene mrene deleted the fix/pwr-ice-framing branch January 24, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants