add failing test #46
Open
add failing test #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
With #47 being merged, I guess we can tackle this one again. Tried to rebase it, but it's currently failing. Do you think we should make the test pass or shall we close the PR? 🤔 |
3accceb
to
38a2dfb
Compare
I think the test should pass. But on the other hand, with solid65 on the way, there will be more tests to come. This will look at decimal mode much more stringently as well and maybe find more bugs I haven't.
I've gone and rebased it in case we want to proceed with it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is connected to issue #45, which is really about what happens in decimal mode if we're working with bytes that are not valid BCD.
So this commit adds a failing test, which is basically the output from Visual6502 after running the short program in the Issue I filed.