Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request #14

Merged
merged 5 commits into from
Oct 10, 2019
Merged

Pull request #14

merged 5 commits into from
Oct 10, 2019

Conversation

abbadon1334
Copy link
Contributor

i have make some changes to make it working again, feel free to merge it.

@mre
Copy link
Owner

mre commented Oct 10, 2019

Thanks @abbadon1334,
these are all very great changes. 😊
One more thing before we merge: could you change the .travis.yml to test on 7.2 instead of 5.x? This way, the build would be green again. I think this sections needs some updating:
https://github.com/mre/PHPench/blob/master/.travis.yml#L4-L7

@abbadon1334
Copy link
Contributor Author

thank to you.
feel free to add the others : https://github.com/abbadon1334/PHPench

I think the original MedianAggregator was wrong, i think i fixed it.

@mre mre merged commit 215c45a into mre:master Oct 10, 2019
@mre
Copy link
Owner

mre commented Oct 10, 2019

Whoop whoop. Thanks! 🎃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants