feat(lsp): add command to reload lsp settings #309
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the discussion we had in #286, I found out how to reload settings using
workspace/didChangeConfiguration
.Turns out the lsp server responds by a
workspace/configuration
where the server actually pulls the new configuration, since the server can cache configuration and decides whether it needs to actually pull the config.nvim
handles it, but we need to set theclient.settings
table to the new configuration before sending theworkspace/didChangeConfiguration
because it seems to be the one used by nvim to send the actual config.I added this feature as a command because it made sense to me, let me know if it does not for you.
Once again, tested the changes on https://github.com/GuillaumeLagrange/neoconf-repro and it works for me.
Cheers