fix(testables): Prevent using nextest for doctests #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When `cargo-nextest` is detected, it becomes the executable to trigger `testable` runnables. Unfortunally, `nextest` does not support doc tests. This causes the doctest runnables to fail when the binary is available on the path. This commit prevents the use of 'nextest' for 'doctest' runnables, falling back to the `cargo test --doc` executable in this case. This way, we can do `:RustLsp testables` and run both `#[tests]` and `doctests` properly.
mrcjkb
reviewed
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
cargo-nextestis detected, it becomes the executable to triggertestablerunnables.Unfortunally,
nextestdoes not support doc tests. This causes the doctest runnables to fail when the binary is available on the path.This commit prevents the use of 'nextest' for 'doctest' runnables, falling back to the
cargo test --docexecutable in this case.This way, we can do
:RustLsp testablesand run both#[tests]anddoctestsproperly.Review Checklist
If applicable: