Skip to content

Commit

Permalink
Remove all answer placeholder checks as they can be confusing at time…
Browse files Browse the repository at this point in the history
…s for some learners
  • Loading branch information
henryken committed May 16, 2020
1 parent c395c84 commit f4a0f66
Show file tree
Hide file tree
Showing 28 changed files with 28 additions and 354 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_is_not_empty, test_answer_placeholders_text_deleted
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -31,5 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_is_not_empty, test_answer_placeholders_text_deleted
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -31,5 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_is_not_empty, test_answer_placeholders_text_deleted
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -31,5 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_answer_placeholders_text_deleted, test_is_not_empty
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -31,5 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_is_not_empty, test_answer_placeholders_text_deleted
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -31,5 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
16 changes: 1 addition & 15 deletions learning/katas/python/Common Transforms/Filter/Filter/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_filter():
placeholders = get_answer_placeholders()
placeholder = placeholders[0]

if 'beam.Filter' in placeholder:
passed()
else:
failed('Use beam.Filter')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -42,6 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_filter()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_is_not_empty, test_answer_placeholders_text_deleted
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -31,5 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_filter():
placeholders = get_answer_placeholders()
placeholder = placeholders[0]

if 'beam.WithKeys' in placeholder:
passed()
else:
failed('Use beam.WithKeys')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -44,6 +32,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_filter()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_is_not_empty, test_answer_placeholders_text_deleted
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -41,5 +40,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_is_not_empty, test_answer_placeholders_text_deleted
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -35,5 +34,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_combine_placeholders():
placeholders = get_answer_placeholders()
placeholder = placeholders[0]

if 'beam.CombinePerKey' in placeholder:
passed()
else:
failed('Use beam.CombinePerKey')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -47,6 +35,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_combine_placeholders()
test_output()
16 changes: 1 addition & 15 deletions learning/katas/python/Core Transforms/Combine/CombineFn/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_combine_placeholders():
placeholders = get_answer_placeholders()
placeholder = placeholders[1]

if 'beam.CombineGlobally' in placeholder:
passed()
else:
failed('Use beam.CombineGlobally')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -42,6 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_combine_placeholders()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_combine_placeholders():
placeholders = get_answer_placeholders()
placeholder = placeholders[1]

if 'beam.CombineGlobally' in placeholder:
passed()
else:
failed('Use beam.CombineGlobally')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -42,6 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_combine_placeholders()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_composite_expand_method():
placeholders = get_answer_placeholders()
placeholder = placeholders[0]

if 'def expand(' in placeholder:
passed()
else:
failed('Override "expand" method')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -42,6 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_composite_expand_method()
test_output()
16 changes: 1 addition & 15 deletions learning/katas/python/Core Transforms/Flatten/Flatten/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_flatten():
placeholders = get_answer_placeholders()
placeholder = placeholders[0]

if 'beam.Flatten' in placeholder:
passed()
else:
failed('Use beam.Flatten')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -42,6 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_flatten()
test_output()
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, get_file_output, \
test_is_not_empty, test_answer_placeholders_text_deleted
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -33,5 +32,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_output()
16 changes: 1 addition & 15 deletions learning/katas/python/Core Transforms/Map/FlatMap/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_flatmap():
placeholders = get_answer_placeholders()
placeholder = placeholders[0]

if 'beam.FlatMap' in placeholder:
passed()
else:
failed('Use beam.FlatMap')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -42,6 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_flatmap()
test_output()
16 changes: 1 addition & 15 deletions learning/katas/python/Core Transforms/Map/Map/tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,19 +14,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.

from test_helper import failed, passed, \
get_answer_placeholders, get_file_output, test_is_not_empty, \
test_answer_placeholders_text_deleted


def test_map():
placeholders = get_answer_placeholders()
placeholder = placeholders[0]

if 'beam.Map' in placeholder:
passed()
else:
failed('Use beam.Map')
from test_helper import failed, passed, get_file_output, test_is_not_empty


def test_output():
Expand All @@ -42,6 +30,4 @@ def test_output():

if __name__ == '__main__':
test_is_not_empty()
test_answer_placeholders_text_deleted()
test_map()
test_output()
Loading

0 comments on commit f4a0f66

Please sign in to comment.