Skip to content

Commit

Permalink
Got rid of reference to windmill_service_streaming_rpc_batching exper…
Browse files Browse the repository at this point in the history
…iment (apache#7728)

* There is no need to predicate WindmillServiceStreamingRpcBatchLimitFactory on the windmill_service_streaming_rpc_batching experiment. That experiment is now fully rolled out.

* Fixed argument to streamingEngineEnabled.
  • Loading branch information
drieber authored and aaltay committed Feb 5, 2019
1 parent 8ee1a27 commit f31ae86
Showing 1 changed file with 1 addition and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -200,11 +200,7 @@ public static class WindmillServiceStreamingRpcBatchLimitFactory
public Integer create(PipelineOptions options) {
StreamingDataflowWorkerOptions streamingOptions =
options.as(StreamingDataflowWorkerOptions.class);
if (streamingEngineEnabled(streamingOptions)
&& hasExperiment(streamingOptions, "windmill_service_streaming_rpc_batching")) {
return Integer.MAX_VALUE;
}
return 1;
return streamingEngineEnabled(streamingOptions) ? Integer.MAX_VALUE : 1;
}
}
}

0 comments on commit f31ae86

Please sign in to comment.