Skip to content

Commit

Permalink
remove LP indicator (apache#11937)
Browse files Browse the repository at this point in the history
  • Loading branch information
lostluck committed Jun 5, 2020
1 parent a560ed2 commit d58fb74
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions sdks/go/pkg/beam/core/graph/coder/stringutf8.go
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ import (

const bufCap = 64

// EncodeStringUTF8LP encodes a UTF string with a length prefix.
func EncodeStringUTF8LP(s string, w io.Writer) error {
// EncodeStringUTF8 encodes a UTF8 string with a length prefix.
func EncodeStringUTF8(s string, w io.Writer) error {
if err := EncodeVarInt(int64(len(s)), w); err != nil {
return err
}
Expand Down Expand Up @@ -73,8 +73,8 @@ func decodeStringUTF8(l int64, r io.Reader) (string, error) {
return builder.String(), nil
}

// DecodeStringUTF8LP decodes a length prefixed utf8 string.
func DecodeStringUTF8LP(r io.Reader) (string, error) {
// DecodeStringUTF8 decodes a length prefixed UTF8 string.
func DecodeStringUTF8(r io.Reader) (string, error) {
l, err := DecodeVarInt(r)
if err != nil {
return "", err
Expand Down
4 changes: 2 additions & 2 deletions sdks/go/pkg/beam/core/graph/coder/stringutf8_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -106,11 +106,11 @@ func TestEncodeDecodeStringUTF8LP(t *testing.T) {
want := s
t.Run(want, func(t *testing.T) {
var build strings.Builder
if err := EncodeStringUTF8LP(want, &build); err != nil {
if err := EncodeStringUTF8(want, &build); err != nil {
t.Fatal(err)
}
buf := bytes.NewBufferString(build.String())
got, err := DecodeStringUTF8LP(buf)
got, err := DecodeStringUTF8(buf)
if err != nil && err != io.EOF {
t.Fatal(err)
}
Expand Down

0 comments on commit d58fb74

Please sign in to comment.