Fix scrolling of long query in input field

[ghost]

How to reproduce:

echo | pick -q $( seq -s ":" 1 $COLUMNS )

and pressing left arrow key several times: nothing happens ... at some point the input field scrolls, but cursor position is out of sync and entering new characters messes up the query ...

[mptre]

Nice catch. Can we do something simpler like the diff below, lightly tested:

diff --git a/pick.c b/pick.c
index 768c075..41ddba0 100644
--- a/pick.c
+++ b/pick.c
@@ -276,8 +276,7 @@ eager_strpbrk(const char *string, const char *separators)
 const struct choice *
 selected_choice(void)
 {
-	size_t	cursor_position, i, j, length;
-	size_t	xscroll = 0;
+	size_t	cursor_position, i, j, length, xscroll;
 	char	buf[6];
 	int	choices_count, word_position;
 	int	selection = 0;
@@ -290,10 +289,10 @@ selected_choice(void)
 	for (;;) {
 		tty_putp(cursor_invisible, 0);
 		tty_putp(carriage_return, 1);	/* move cursor to first column */
-		if (cursor_position >= xscroll + columns)
+		if (cursor_position >= (size_t)columns)
 			xscroll = cursor_position - columns + 1;
-		if (cursor_position < xscroll)
-			xscroll = cursor_position;
+		else
+			xscroll = 0;
 		print_line(&query[xscroll], query_length - xscroll, 0, -1, -1);
 		choices_count = print_choices(yscroll, selection);
 		if ((size_t)choices_count - yscroll < choices.length

[ghost]

Indeed simpler and works also great ...

[mptre]

Great, merged as 1ef7970.