Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give this a full refresh (libraries, php version, code style, tests) #115

Merged
merged 5 commits into from
May 27, 2020
Merged

Give this a full refresh (libraries, php version, code style, tests) #115

merged 5 commits into from
May 27, 2020

Conversation

okaufmann
Copy link
Collaborator

Hi,

As I'm using this library in some of my products I detected it's not compatible with Laravel 7.
After got my hands on it, I decided to give this a whole refresh.

This is what I did:

  • Updated all libraries to the latest versions
  • Dropped Laravel version older than 7 (cause innovation ftw β€¦πŸ’β€β™‚οΈ)
  • Restructure the tests into its own namespaces
  • Make tests compatible with sqlite

If you want these changes I suggest to release a new major release...

fix tests


refresh
@okaufmann
Copy link
Collaborator Author

Any ideas how to set the version of phpunit to make it work with all testes php versions?

@okaufmann
Copy link
Collaborator Author

I finally got time to fix the tests and also convert them to be run as github actions.

@okaufmann
Copy link
Collaborator Author

you can check build status on my forks actions page: https://github.com/okaufmann/teamwork/actions

@necenzurat
Copy link

Hey, awesome job, quick question, can you make it a composer package since this version is abandonware?

And if anyone is wondering how to use this version, you can do this in your composer.json file

"repositories": [{
    "type": "vcs",
    "url": "https://github.com/okaufmann/teamwork"
}],
"require": {
    "php": "^7.2",
    "mpociot/teamwork": "dev-master",
}

@okaufmann okaufmann merged commit 02bbd50 into mpociot:master May 27, 2020
@necenzurat
Copy link

@mpociot can you publish a new release?

@okaufmann
Copy link
Collaborator Author

I'll do as soon I have checked everything working ✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants