Catch JWSErrors in jwt.decode()
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So far exceptions raised in `jws.verify()` weren't caught in the above function, which led to it raising (undocumented) exceptions from the underlying module. This commit transforms said exceptions. This includes cases of invalid payload padding, error handling for which had previously been attached to the `json.loads()` call.
Current coverage is 94.24%@@ master #20 diff @@
==========================================
Files 7 7
Lines 415 417 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 391 393 +2
Misses 24 24
Partials 0 0 |
|
lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far exceptions raised in
jws.verify()weren't caught in the abovefunction, which led to it raising (undocumented) exceptions from the
underlying module.
This commit transforms said exceptions. This includes cases of invalid
payload padding, error handling for which had previously been attached
to the
json.loads()call.