Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle signature verification faliures #11

Merged
merged 1 commit into from
Jan 5, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions jose/exceptions.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,10 @@ class JWSError(JOSEError):
pass


class JWSSignatureError(JWSError):
pass


class JWSAlgorithmError(JWSError):
pass

Expand Down
5 changes: 4 additions & 1 deletion jose/jws.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from jose.jwk import get_algorithm_object
from jose.constants import ALGORITHMS
from jose.exceptions import JWSError
from jose.exceptions import JWSSignatureError
from jose.utils import base64url_encode
from jose.utils import base64url_decode

Expand Down Expand Up @@ -203,7 +204,9 @@ def _verify_signature(payload, signing_input, header, signature, key='', algorit
key = alg_obj.prepare_key(key)

if not alg_obj.verify(signing_input, key, signature):
raise JWSError('Signature verification failed')
raise JWSSignatureError()

except JWSSignatureError:
raise JWSError('Signature verification failed.')
except JWSError:
raise JWSError('Invalid or unsupported algorithm: %s' % alg)