Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: adds an example to --pref option #724

Merged
merged 2 commits into from
Jan 3, 2017
Merged

docs: adds an example to --pref option #724

merged 2 commits into from
Jan 3, 2017

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 commented Jan 3, 2017

No description provided.

@coveralls
Copy link

coveralls commented Jan 3, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 4e15f41 on kumar303:pref-docs into 94e9a13 on mozilla:master.

rpl
rpl reviewed Jan 3, 2017
View reviewed changes
src/program.js
describe: 'Launch firefox with custom preferences. Lightweight ' +
'alternative to creating custom profile.',
describe: 'Launch firefox with a custom preference. Example: ' +
'--pref=general.useragent.locale=fr-FR. ' +
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kumar303 nit, how about:

'...' +
' (e.g. --pref=general.useragent.locale=fr-FR). ' +
'...'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure

@coveralls
Copy link

coveralls commented Jan 3, 2017 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 397b920 on kumar303:pref-docs into 94e9a13 on mozilla:master.

rpl
rpl approved these changes Jan 3, 2017
View reviewed changes
Copy link
Member

@rpl rpl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kumar303
Copy link
Contributor Author

kumar303 commented Jan 3, 2017

Thanks!

@kumar303 kumar303 merged commit c4bd6ba into mozilla:master Jan 3, 2017
@kumar303 kumar303 deleted the pref-docs branch January 3, 2017 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpl rpl rpl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kumar303 @coveralls @rpl