Skip to content
This repository has been archived by the owner on May 22, 2021. It is now read-only.

Popup for delete button attached #698

Merged

Conversation

himanish-star
Copy link
Contributor

fixes : #217
@dannycoates , I'm very sorry as I'm troubling you again. As mentioned by @SoftVision-CiprianMuresan , pull request #684 didn't fix the issue in firefox . So I have made the corrections. The error was caused due to instertion of div inside button. Now I have fixed that too. Well do you also want me to modify the css for the popup for mobile view too in this PR.

The below GIF can be seen
ezgif com-video-to-gif 7
Mobile View Of Popup
image

@dannycoates dannycoates merged commit 9811a9a into mozilla:master Jan 9, 2018
@dannycoates
Copy link
Contributor

Thanks @himanish-star

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete button does not bring up a confirmation dialog
2 participants