This repository has been archived by the owner on May 22, 2021. It is now read-only.
Password UI nits #612
Merged
Password UI nits #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericawright
force-pushed
the
password-nits
branch
from
3429837
to
3cb6d77
Compare
flodolo
reviewed
Oct 23, 2017
| @@ -85,5 +85,5 @@ footerLinkPrivacy = Privacy | |||
| footerLinkTerms = Terms | |||
| footerLinkCookies = Cookies | |||
| requirePasswordCheckbox = Require a password to download this file | |||
| addPasswordButton = Add Password | |||
| incorrectPassword = Incorrect password. Try again? | |||
| addPasswordButton = Add password | |||
There was a problem hiding this comment.
It's OK to change case without using a new ID.
public/locales/en-US/send.ftl
Outdated
| addPasswordButton = Add Password | ||
| incorrectPassword = Incorrect password. Try again? | ||
| addPasswordButton = Add password | ||
| incorrectPassword = Incorrect password. Try again. |
There was a problem hiding this comment.
Unfortunately this needs a new string ID if we want locales to update accordingly.
|
Let's copy the formatting of the URL field, with the field on top and the button below. |
ericawright
force-pushed
the
password-nits
branch
from
3cb6d77
to
5cdc13c
Compare
ericawright
force-pushed
the
password-nits
branch
from
5cdc13c
to
1e4d664
Compare
|
@clouserw can you find a reviewer for this too? |
…hashed asset name
|
This looks great, thanks @ericawright! 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
smaller screens:
Tested on release versions of Chrome and Firefox
to display passwords with spaces properly.Fixes: #587.
Fixes: #610.
Fixes: #599.
Fixes: #591.
Fixes: #613.