This repository has been archived by the owner on May 22, 2021. It is now read-only.
Add optional password to the download url #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flodolo
reviewed
Oct 9, 2017
public/locales/en-US/send.ftl
Outdated
| unlockInputLabel = Enter Password | ||
| unlockInputPlaceholder = Password | ||
| unlockButtonLabel = Unlock | ||
| downloadFileTitle = Download Encypted File |
public/locales/en-US/send.ftl
Outdated
| @@ -80,3 +84,6 @@ footerLinkAbout = About Test Pilot | |||
| footerLinkPrivacy = Privacy | |||
| footerLinkTerms = Terms | |||
| footerLinkCookies = Cookies | |||
| requirePassword = Require a password to download this file | |||
There was a problem hiding this comment.
Can you use a string ID that describes better the role of this string, or add a localization comment to explain the context?
public/locales/en-US/send.ftl
Outdated
| @@ -80,3 +84,6 @@ footerLinkAbout = About Test Pilot | |||
| footerLinkPrivacy = Privacy | |||
| footerLinkTerms = Terms | |||
| footerLinkCookies = Cookies | |||
| requirePassword = Require a password to download this file | |||
| addPassword = Add Password | |||
There was a problem hiding this comment.
Same here, can you add some context? I assume it's a button, or a link.
dannycoates
force-pushed
the
split
branch
3 times, most recently
from
dcf0781
to
c9a2bfa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an optional password to the download url of the shared file. Also, file metadata is now encrypted, so the server will no longer know the filename or type of all new files, not just password protected ones.
After a password is set the server requires verification of the password before returning both the encrypted file metadata and encrypted file.
Known issues:
Closes #381
Closes #69