This repository has been archived by the owner on May 22, 2021. It is now read-only.
404 page #506
Merged
404 page #506
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@varghesethomase We should only render the notfound page for HTML endpoints; some of the 404s are API endpoints and will not be expecting a notfound HTML page. |
|
@abhinadduri Could you help me with identifying the APIs so that i can revert the necessary code? |
|
I guess the only non XHR request out there is for the /download url. I am reverting all the other code. And have updated the PR. |
|
Thank you @varghesethomase 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #446 by replacing all
res.sendStatus(404);withres.status(404).render('notfound');