This repository has been archived by the owner on May 22, 2021. It is now read-only.
added webpack-dev-middleware #493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdehaan
reviewed
Aug 10, 2017
server/server.js
Outdated
| @@ -38,6 +38,17 @@ function prodLangs() { | |||
|
|
|||
| const availableLanguages = conf.l10n_dev ? allLangs() : prodLangs(); | |||
|
|
|||
| if (conf.env !== 'production') { | |||
There was a problem hiding this comment.
Just to confirm, the send.stage.mozaws.net server runs in a NODE_ENV="production" environment, correct?
There was a problem hiding this comment.
yeah, but === 'development' is better
dannycoates
force-pushed
the
webpack-dev
branch
from
97b262d
to
21b7f16
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now
npm startornpm run devwill rebuild js bundles when the source changes on localhost.