This repository has been archived by the owner on May 22, 2021. It is now read-only.
Modify popup delete dialog #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youwenliang
force-pushed
the
ui-refinement
branch
from
cab5b44
to
cd8b09f
Compare
dnarcese
reviewed
Jul 27, 2017
public/main.css
Outdated
| .popup .popuptext::after { | ||
| left: auto; | ||
| right: 36px; | ||
| } |
There was a problem hiding this comment.
I think the popup should move to the left earlier. It causes horizontal scrolling at any screen between widths 768px and 920px.
There was a problem hiding this comment.
sounds good to me!
fix responsive
dnarcese
approved these changes
Jul 27, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #326
Also, expand feedback button by default in mobile view since there's no hover state.