This repository has been archived by the owner on May 22, 2021. It is now read-only.
fixes issues 195 and 192 #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdehaan
reviewed
Jul 13, 2017
server/server.js
Outdated
| !meta.hasOwnProperty('aad') || | ||
| !meta.hasOwnProperty('id') || | ||
| !meta.hasOwnProperty('filename') | ||
| !meta.hasOwnProperty('filename' || |
There was a problem hiding this comment.
I think... this is wrong.
!meta.hasOwnProperty('filename') ||
!validateIV(meta.id)
There was a problem hiding this comment.
Oops, nice catch! Messed up some indenting and ended up with that.
This was referenced Jul 13, 2017
dannycoates
reviewed
Jul 13, 2017
frontend/src/download.js
Outdated
| @@ -65,7 +65,7 @@ $(document).ready(function() { | |||
| return; | |||
| }) | |||
| .then(([decrypted, fname]) => { | |||
| name.innerText = fname; | |||
| name.innerText = decodeURIComponent(fname); | |||
There was a problem hiding this comment.
can we move the decode into fileReceiver.js?
There was a problem hiding this comment.
Yeah, will do.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #192
Fixes #195