1581556: Register lifecycle observers on the main thread #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
============================================
+ Coverage 70.88% 70.95% +0.06%
- Complexity 247 250 +3
============================================
Files 64 65 +1
Lines 3837 3846 +9
Branches 589 590 +1
============================================
+ Hits 2720 2729 +9
Misses 682 682
Partials 435 435
Continue to review full report at Codecov.
|
badboy
approved these changes
Sep 20, 2019
Dexterp37
requested changes
Sep 20, 2019
glean-core/android/src/main/java/mozilla/telemetry/glean/Glean.kt
Outdated
Show resolved
Hide resolved
184f6d0
to
27386fd
Compare
travis79
approved these changes
Sep 20, 2019
badboy
requested changes
Sep 24, 2019
27386fd
to
808c8d2
Compare
mdboom
commented
Sep 27, 2019
| /** | ||
| * Assert that this code is run on the main (UI) thread. | ||
| */ | ||
| fun assertOnUiThread() { |
There was a problem hiding this comment.
This is ported from android-components...
Dexterp37
approved these changes
Sep 30, 2019
badboy
approved these changes
Sep 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a port of mozilla-mobile/android-components#4477