Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

people should refer to docker images using tags #9

Closed
KathyReid opened this issue Feb 23, 2021 · 3 comments · Fixed by #12
Closed

people should refer to docker images using tags #9

KathyReid opened this issue Feb 23, 2021 · 3 comments · Fixed by #12
Assignees
@KathyReid
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone
Beta release

Comments

@KathyReid
Copy link
Contributor

KathyReid commented Feb 23, 2021 •
edited
Loading

Moved from https://github.com/JRMeyer/deepspeech-playbook/issues/33 raised by @lissyx

You will need the id of the Docker image that you created when you set up your DeepSpeech training environment.

We should rather instruct people to apply tags to their image so they can e.g., docker run [...] deepspeech-local:stable.
@KathyReid
Copy link
Contributor Author

I think this is a duplicate of #10, closing

@lissyx lissyx reopened this Feb 23, 2021
@lissyx
Copy link
Collaborator

lissyx commented Feb 23, 2021

It's not a dupe, I think you pasted the wrong text from the original issue:

You will need the id of the Docker image that you created when you set up your DeepSpeech training environment.

We should rather instruct people to apply tags to their image so they can e.g., docker run [...] deepspeech-local:stable.

@KathyReid
Copy link
Contributor Author

Aaah, sorry. Yes, good point, and sorry for the error.

@KathyReid KathyReid self-assigned this Feb 23, 2021
@KathyReid KathyReid added documentation Improvements or additions to documentation enhancement New feature or request labels Feb 23, 2021
@KathyReid KathyReid added this to the Beta release milestone Feb 23, 2021
KathyReid added a commit that referenced this issue Feb 24, 2021
@KathyReid
Changed instructions to use name and tag of image instead of id to ma…
9255ccc 
…ke it easier, resolves #9
@KathyReid KathyReid mentioned this issue Feb 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KathyReid KathyReid

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
Beta release
Development

Successfully merging a pull request may close this issue.

Changed instructions to use name and tag of image instead of id to ma… mozilla/deepspeech-playbook
2 participants
@KathyReid @lissyx