Skip to content
This repository has been archived by the owner on Mar 6, 2024. It is now read-only.

[build] 'codecov' PR check should not mark PRs as failing tests #910

Closed
garvankeeley opened this issue May 25, 2018 · 2 comments
Closed
Assignees
Labels

Comments

@garvankeeley
Copy link
Contributor

In my PR with no code changes, codecov reports a minor regression in coverage, and marks my PR with the 'X' for failed tests. This is incorrect. Either codecov should be set to allow for greater regression before failing, or the tool should be info-only and not mark PRs with a failure indicator.

@garvankeeley
Copy link
Contributor Author

@boek do you have codecov access?

@nojunpark nojunpark self-assigned this May 25, 2018
@nojunpark
Copy link

I'll handle this

garvankeeley added a commit that referenced this issue May 28, 2018
Copied this logic from focus android codecov.yml
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 14, 2024
…rts false negatives. (mozilla-mobile/focus-ios#924)

Fix  mozilla-mobile/focus-ios#910 - codecov.yml needs tolerance or reports false negatives.
isabelrios pushed a commit to isabelrios/firefox-ios that referenced this issue Feb 20, 2024
…race or reports false negatives. (mozilla-mobile/focus-ios#924)

Fix  mozilla-mobile/focus-ios#910 - codecov.yml needs tolerance or reports false negatives.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants