Only username should be used for construction #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to protocol specification, only username should be used for construction (without domain name). https://tools.ietf.org/html/rfc2759#section-8.2
| @@ -47,6 +47,13 @@ def getUserName(self): | |||
| assert self.isComplete() | |||
| return self.handshake['response'].getName() | |||
|
|
|||
| def getOnlyUserName(self): | |||
There was a problem hiding this comment.
It looks like your indentation is way off here. Tabs vs spaces?
There was a problem hiding this comment.
Looks like. Fixed. Look newest commit to this pull request.
|
Thanks, is there a reason not to just make getUserName do this? |
|
My initial patch was doing that. But, on the end it's really worth displaying domainName as domain name have to be specified during logon once NT hash is cracked. So, it is useful information worth having in output. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to protocol specification, only username should be used for
construction (without domain name).
https://tools.ietf.org/html/rfc2759#section-8.2