Add InterceptResponse to the Plugin interface #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #205 +/- ##
==========================================
- Coverage 71.10% 70.99% -0.11%
==========================================
Files 26 26
Lines 2710 2717 +7
==========================================
+ Hits 1927 1929 +2
- Misses 660 665 +5
Partials 123 123
☔ View full report in Codecov by Sentry. |
LeonHuston
approved these changes
May 3, 2023
pkqk
approved these changes
May 3, 2023
There was a problem hiding this comment.
Agree with @LeonHuston comment about examples, we should probably have one for each plugin method.
Changes look good.
InterceptResponse is called after bramble has finished executing a request. It can be used to inspect and/or modify the response bramble will return.
nmaquet
force-pushed
the
intercept-response
branch
from
21d7cd9
to
8bba076
Compare
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InterceptResponse is called after bramble has finished executing a request. It can be used to inspect and/or modify the response bramble will return.
Added to help with #204