Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI job with minimal dependencies #520

Merged
merged 7 commits into from
Aug 27, 2024
Merged

CI job with minimal dependencies #520

merged 7 commits into from
Aug 27, 2024

Conversation

volkm
Copy link
Contributor

@volkm volkm commented Apr 11, 2024

Added CI job with minimal dependencies based on the Docker image storm-basesystem:minimal_dependencies:

The CI job already detected multiple issues:

  • shipped Carl did not compile without CLN and GiNaC
  • minimal build of Carl needs changes of CI job with minimal dependencies carl-storm#40. In particular, the patch step of Eigen in the shipped Carl requires a valid git committer.
  • a larger number of tests are failing due to missing SMT solver
  • Glpk needed reconfiguration after removing examples folder

@tquatmann
Copy link
Member

current state LGTM!

@volkm volkm marked this pull request as draft June 7, 2024 09:02
@volkm volkm marked this pull request as ready for review July 8, 2024 11:09
@volkm volkm requested a review from tquatmann July 8, 2024 11:10
Copy link
Member

@tquatmann tquatmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one minor comment.

resources/3rdparty/glpk-5.0/Makefile.am Show resolved Hide resolved
@volkm volkm merged commit 6d0e4f4 into moves-rwth:master Aug 27, 2024
14 checks passed
@volkm volkm deleted the ci_z3 branch August 27, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants