Add64bit support #38
Open
Add64bit support #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mourner and thanks a lot for the great libs that you share with the world!
I've been a user of Rbush for a few months now but only recently found out about Flatbush as a potential replacement due to its performance boost.
Although some C++ variants seem to already be available in the wild, I couldn't find anything that was up-to-date and that would exploit, arguably, one of its main strengths, of being able to recreate the exact state from a byte buffer on the other side, so I quickly put together my own interpretation of it in cpp.
This PR would be adding functionality for BigInt type (probably a niche scenario) as I'm planning to enable support for 64-bit integrals in my code as well (https://github.com/chusitoo/flatbush/tree/Support64Bit).
I also ported back some unit tests from my implementation that I found helpful, hoping to also improve test coverage on this side of things.
Cheers,
Alex.