Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: host logging modes (disabled, input, everything) #188

Merged
merged 3 commits into from
Jul 8, 2020

Conversation

moul
Copy link
Owner

@moul moul commented Jul 4, 2020

  • update CLI: host create --logging MODE
  • update CLI: host update --logging MODE
  • update CLI: add Logging column in host ls
  • update pipe() to support new host logging modes (disabled, input, everything)
  • update doc

fix #166
fix #57
related with #73

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Jul 4, 2020
@moul moul changed the title feat: host logging modes (disabled, commands, everything) WIP feat: host logging modes (disabled, commands, everything) Jul 4, 2020
@trafico-bot trafico-bot bot added 🚧 WIP Still work-in-progress, please don't review and don't merge and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 4, 2020
@moul moul changed the title WIP feat: host logging modes (disabled, commands, everything) WIP feat: host logging modes (disabled, input, everything) Jul 4, 2020
@moul moul self-assigned this Jul 4, 2020
@moul moul changed the title WIP feat: host logging modes (disabled, input, everything) feat: host logging modes (disabled, input, everything) Jul 4, 2020
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Jul 4, 2020
@moul
Copy link
Owner Author

moul commented Jul 4, 2020

Demo

Demo

https://www.youtube.com/watch?v=5VRZ0j-AybY


Please tell me if it works as expected for you

@jle64
Copy link
Contributor

jle64 commented Jul 6, 2020

@moul Awesome ! Works for me.

@moul moul merged commit e43bb55 into master Jul 8, 2020
@moul moul deleted the dev/moul/fix-166 branch July 8, 2020 08:12
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Jul 8, 2020
@github-actions
Copy link

github-actions bot commented Jul 8, 2020

🎉 This PR is included in version 1.13.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement help wanted ✨ Merged Pull Request has been merged successfully released
Projects
None yet
2 participants