Skip to content

Commit

Permalink
ci: start sccache early and throw away the S3 access key
Browse files Browse the repository at this point in the history
This avoids accidentally leaking the key in the build log.
  • Loading branch information
piscisaureus committed Dec 20, 2018
1 parent 9e70b0d commit aac92cb
Show file tree
Hide file tree
Showing 2 changed files with 13 additions and 0 deletions.
8 changes: 8 additions & 0 deletions .appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -341,6 +341,11 @@ before_build:
foreach { "$env:DENO_BUILD_PATH\$($Matches[1])" }
Set-FilesNeeded -Auto -Path $outputs -Reason "Build dependency graph"
# Start sccache, then throw away the S3 access key.
- ps: |-
sccache --start-server
$env:AWS_SECRET_ACCESS_KEY = $null
build_script:
# Build with Cargo first. Both builds produce a deno.exe in the same dir. We
# want the final one (which gets tested and released) to be built by Ninja.
Expand All @@ -363,6 +368,9 @@ after_test:
# Remove stale files and empty dirs from the build directory.
- ps: Stop-TraceFilesNeeded

# Stop sccache and show stats.
- ps: sccache --stop-server

# Verify that the build is fully up-to-date. Running ninja should be a no-op.
# This catches erroneous file cleanup, and incorrectly set up build deps.
- ps: |-
Expand Down
5 changes: 5 additions & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -55,6 +55,10 @@ install:
rm -rf "$RUSTUP_HOME"toolchains/*/share
before_script:
- ./tools/setup.py
# Start sccache, then throw away the S3 access key.
- |-
sccache --start-server
unset AWS_SECRET_ACCESS_KEY
script:
- |-
# Check lint and format.
Expand Down Expand Up @@ -84,6 +88,7 @@ script:
./tools/build.py -C target/release -j2
DENO_BUILD_MODE=release ./tools/test.py
- sccache --stop-server
before_deploy:
- gzip -c target/release/deno > target/release/deno_${TRAVIS_OS_NAME}_x64.gz
deploy:
Expand Down

0 comments on commit aac92cb

Please sign in to comment.