-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android AppCompat Beta 1.4.0-beta01 Release Breaks Builds #37
Comments
Thank you for your contribution
If you think this will fix the issue
Kindly open pull request and i will merge it
Thank you
Regards,
…___________________________
Mostafa Mansour
Software Engineer
00971 524988466
On 30 Sep 2021, at 10:05 PM, Dan Adler ***@***.***> wrote:
The following line <framework src="androidx.appcompat:appcompat:+" /> in the plugin.xml file is now breaking Android Builds for SDKCompile versions less than 31 which is what I imagine all Capacitor projects are running with.
With the release of the new 1.4.0-beta01 : https://developer.android.com/jetpack/androidx/releases/appcompat which happened yesterday all builds using this plugin with SDK less than 31 will now break.
I would recommended instead of using + we just lock the version to 1.3.1 as this is the most recent stable version per the site. Let me know your thoughts and I can open a PR if need be. I've fixed it in our build pipeline for now by hacking around it but wouldn't mind solving it at the core for others using the plugin / having the same issue.
Thanks for the great plugin!
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub<#37>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABSFOB4LX47AD7SGXTFAPH3UESRIJANCNFSM5FC5AULQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
camhungh
pushed a commit
to camhungh/previewAnyFile
that referenced
this issue
Oct 1, 2021
Hi @danbunkr , @mostafa-mansour1 , Thank you so much. |
@mostafa-mansour1, could you push the fixed version to NPM? Thank you very much! |
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The following line
<framework src="androidx.appcompat:appcompat:+" />
in the plugin.xml file is now breaking Android Builds for SDKCompile versions less than 31 which is what I imagine all Capacitor projects are running with.With the release of the new 1.4.0-beta01 : https://developer.android.com/jetpack/androidx/releases/appcompat which happened yesterday all builds using this plugin with SDK less than 31 will now break.
I would recommended instead of using
+
we just lock the version to 1.3.1 as this is the most recent stable version per the site. Let me know your thoughts and I can open a PR if need be. I've fixed it in our build pipeline for now by hacking around it but wouldn't mind solving it at the core for others using the plugin / having the same issue.Thanks for the great plugin!
The text was updated successfully, but these errors were encountered: