corrade-rc: allow shorthand filename specification #163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If no alias, nullTerminated or align options are needed or the global values are sufficient, having to write a [file] section for each file is overly verbose. This allows to specify filename= options directly in the global configuration section. It's filename= and not file= in order to not have to further complicate the CMake parsing routine that extract dependency information from the file -- this way it doesn't even need to be changed. TODO: while basic support for this was easy enough, the filesystem group override code needs to be adapted and tested for this, which involves copying the file somewhere temporary and changing the contents (because we can't make use of an alias in this scenario) TODO: there's also a newly uncovered bug, see the TODO in Resource.cpp TODO: this also needs to be documented
Codecov ReportBase: 97.98% // Head: 97.93% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 97.98% 97.93% -0.06%
==========================================
Files 136 136
Lines 11151 11170 +19
==========================================
+ Hits 10926 10939 +13
- Misses 225 231 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought this was a quickie to whip up after 9ef4b4a but ultimately it wasn't, as always, and I ran out of time allocated for "random stuff".
If no
alias,nullTerminatedoralignoptions are needed or the global values are sufficient, having to write a[file]section for each file is overly verbose. This allows to specifyfilenameoptions directly in the global configuration section.It's
filenameand notfilein order to not have to further complicate the CMake parsing routine that extract dependency information from the file -- this way it doesn't even need to be changed.Things left to do:
aliasin this scenario)