Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Free memory on application exit #209

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Free memory on application exit #209

merged 4 commits into from
Dec 12, 2023

Conversation

carshadi
Copy link
Member

Addresses #208

@carshadi
Free memory on exit
f071335 
- nullify references to allow garbage collection of large objects
@carshadi
Fix NullPointerException
8c48df9
@carshadi carshadi added the bug Something isn't working label Nov 29, 2023
@carshadi carshadi marked this pull request as ready for review November 29, 2023 17:39
@carshadi carshadi requested a review from tferr November 29, 2023 17:39
@carshadi carshadi mentioned this pull request Nov 29, 2023
Closed
@tferr
Copy link
Member

tferr commented Dec 11, 2023

@carshadi, this is great. I just wanted to add two things:

  • Reconstruction Viewer was also plagued by similar leaks (b48ca45)
  • SNTService has methods for 'headless' tracing that won't call 'SNTUI#exitRequested()`, so I was thinking to move some of the exit logic elsewhere so it does not rely on the GUI. Agree? I should be able to work on this still this week

@carshadi
Copy link
Member Author

Making the resource disposal independent of the GUI makes sense

@tferr tferr merged commit 19dd9e2 into main Dec 12, 2023
@tferr tferr deleted the free-memory-on-exit branch December 12, 2023 19:39
tferr added a commit that referenced this pull request Dec 21, 2023
@tferr
Bugfix: NPE when running File>Quit and File>Reset and Restart...
1d5b8f7 
... due to the recent changes in #209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tferr tferr Awaiting requested review from tferr

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@carshadi @tferr