Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Squash llama2 into one commit to resolve conflicts #211

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JacksonKearl
Copy link
Collaborator

No description provided.

Copy link
Contributor

@cristianoc cristianoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

There are quite a few commented out lines that can be cleaned up if the current code is stable.

Also, some logic such as prompt truncation might belong to some general functionality rather than one specific kind of model, to avoid repeating similar logic in different places. Though that can be done later.

@cristianoc
Copy link
Contributor

cristianoc commented Oct 2, 2023

Nit: why is the .vsix file name shipped with a release not versioned?

@JacksonKearl
Copy link
Collaborator Author

@cristianoc the bulk of the llm/... edits are carried over exactly from the jesse/llama branch, not sure what @jesse-michael-han wants to do with those. We talked about how it'd make sense to flip the logic somehow so that the context-providing/prompting stuff is dependent on the model rather than the runtime.

In theory basically everything but the exact "executor" function could be handled more or less the same for all runtimes, and a map of some sort could be constructed to associate models with the prompting/context they need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants