-
Notifications
You must be signed in to change notification settings - Fork 146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dev 2.3 #203
Open
cristianoc
wants to merge
96
commits into
main
Choose a base branch
from
dev-2.3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Dev 2.3 #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Vendor tree-sitter-lean Vendor tree-sitter-lean from https://github.com/Julian/tree-sitter-lean * Add Lean to custom parsers. * IR: add Lean parser. * IR: add Lean tests. * IR: correctly build lean tree sitter
* Clean up agents code The agent params are sent from the client, and are the same for all agents. So there's no customisation in practice. Remove redundant class member that were set per agent but were already inherited from the abstract agent class. * Clean up server parameter of agent create.
All agents use messages in the state. This avoids repeating it in every agent.
Statements are redundant: use the body of the file block.
Then statements can be removed.
Items are not required now that Unknown symbols have replaced statements without symbols.
A function can be used to compute the similarity directly.
This allows to capture the symbol inside an expression when available. If the expression corresponds to a recognised metasymbol, then it will be that symbol. Otherwise it will be the string corresponding to the original code, but where the symbol names will be replaces for the corresponding parts of code.
I'm looking at you `vendor/tree-sitter-lean/src/parser.c` with your 100MB and 3MLOC.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.