-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
get_manta_sv, id_ease, website & documentation improvements + minor hot-fixes #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rdmorin
reviewed
Jun 16, 2023
… PR is ready for merging)
rdmorin
reviewed
Jun 16, 2023
mattssca
changed the title
Website Improvements and other hot-fixes
get_manta_sv, id_ease, website & documentation improvements + minor hot-fixes
Jun 27, 2023
As requested by Adam, I checked only function |
vladimirsouza
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes the following updates;
Where applicable, ORCIDs have been added to the DESCRIPTION. Allowing GAMBLR website visitors to click on any of the authors and browse the associated publications from each author, respectively.
New parameter was added to
cnvKomapre
, allowing the user to toggle the appearance of the x-axis labels. This is useful when you want to hide the x-axis labels due to overlaps of the labels. (issue some issues with vignettes #209)Added a new parameter to
pretty_lollipop_plot
that lets the user dictate the name of the file for the exported plot. This seems to be the intended behavior for this function but was never fully implemented. (issue some issues with vignettes #209)New safety check was added to
pretty_lollipop_plot
that returns a useful error message if no genes are provided.Verbose parameter added to
ashm_multi_rainbow plot
, preventing the full region_bed file to be printed if set to FALSE. (issue some issues with vignettes #209)Updated internal call of, now relocated bundled data sets in
ashm_multi_rainbow_plot
.Examples updated for
fancy_circos_plot
as well as the variable used in returning a message to the user when calling this plotting function.Vignettes have been updated to allow for a more tidy output.
Logo on the main README has been updated to the correct size (based on best practices for R package logos).
Package documentation has been regenerated.
Adding missing data sets for
pretty_lollipop_plot function
. The two added datasets seem to be the main reason this function failed for certain GAMBLRs. I do recommend reinstalling theg3viz
package and see if this resolves the problem, if not, the added bundled data should allow such users to call this function successfully.Extensive overhaul of
get_manta_sv
that allows for using cached results (and compiling the cached results). For more info, see the. updated function documentation.A new helper function
id_ease
for dealing with sample IDs and/or metadata. See function docs for more information.The commented-out code for returning normals (
get_gambl_metadata
) has been reenabled and the vignettes have been re-knitted to see if the previous problem that called for this code to be commented out was still around. The vignettes knitted just fine (issueget_gambl_metadata
is broken for normals #190).This PR also includes a hot-fix for
liftover_bedppe
that converts to strings manually (avoid scientific notation in rare cases when R coerces to strings)Lastly, this PR also resolves
mode = "strelka2"
support inget_ssm_by_region
(issue Strelka2 support in get_ssm_by_region appears to be broken #202). Note, since this output only has the standard BED columns,streamlined
is forced to TRUE for this mode. Streamlined is a Boolean parameter that if set to TRUE, only returns two columns in the MAF (Start_Position
andTumour_Sample_Barcode
).Pull Request Checklists
Important: When opening a pull request, keep only the applicable checklist and delete all other sections.
Checklist for all PRs
Required
I tested the new code for my use case (please provide a reproducible example of how you tested the new functionality)
I ensured all dplyr functions that commonly conflict with other packages are fully qualified.
This can be checked and addressed by running
check_functions.pl
and responding to the prompts. Test your code after you do this.I generated the documentation and checked for errors relating to the new function (e.g.
devtools::document()
) and addedNAMESPACE
and all other modified files in the root directory and underman
.I have rebuilt the site with
pkgdown::build_site(lazy = TRUE)
to reflect any updated package documentation.Optional but preferred with PRs
Checklist for New Functions
Required
I documented my function using ROxygen style.)
Adequate function documentation (see new-function documentation template for more info)
Example:
import
statement.Example:
Checklist for changes to existing code
I added/removed arguments to a function and updated documentation for all changed/new arguments
I tested the new code for compatibility with existing functionality in the Master branch (please provide a reprex of how you tested the original functionality)