Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pointer type instead of value #22

Merged
merged 1 commit into from
Mar 7, 2019
Merged

Use pointer type instead of value #22

merged 1 commit into from
Mar 7, 2019

Conversation

morikuni
Copy link
Owner

@morikuni morikuni commented Mar 2, 2019

Changes

Use pointer type instead of value.

Motivation

Since the error chain become a bigger object, pointer type is better to avoid large data copy.

@codecov-io
Copy link

Codecov Report

Merging #22 into master will decrease coverage by 0.31%.
The diff coverage is 95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #22      +/-   ##
==========================================
- Coverage   96.05%   95.74%   -0.32%     
==========================================
  Files           5        5              
  Lines         279      282       +3     
==========================================
+ Hits          268      270       +2     
- Misses          7        8       +1     
  Partials        4        4
Impacted Files Coverage Δ
wrapper.go 99.21% <95%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4875ff...8ac0e51. Read the comment docs.

@morikuni morikuni merged commit 7efe8cc into master Mar 7, 2019
@morikuni morikuni deleted the pointer-type branch March 7, 2019 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants