Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(definition-types): accept custom string for all functions #26

Merged
merged 1 commit into from
Aug 24, 2020

Conversation

raulfdm
Copy link
Collaborator

@raulfdm raulfdm commented Jun 25, 2020

Closes #23 #21

Description

This PR adds a function overload for media.* functions that allow we pass a custom size via string or a specific media query name.

First implementation
image

Secondimplementation
image

Result in VSCode
image

@raulfdm raulfdm force-pushed the add-type-support-for-custom-types branch from b6cd509 to e3815ba Compare June 25, 2020 21:05
@raulfdm raulfdm added the fix label Jun 26, 2020
@KesleyDavid
Copy link

Good morning folks, any release forecast?
I'm in the middle of a project, when I started coding the responsive I discovered this detail

Copy link
Collaborator

@ApacheEx ApacheEx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

In fact, this PR has 3 new lines which solves the problem, rest is formatting by prettier I guess. But, anyways we need it on project level. So, it looks good for me to go.

@raulfdm raulfdm merged commit 3e4351f into master Aug 24, 2020
@larissaiurk
Copy link

Hii! Thanks so much for this!

Seems like the PR for accept custom string has been merged, would it be possible to do a new release with those changes? Or already released and I didn't see...

@raulfdm
Copy link
Collaborator Author

raulfdm commented Feb 25, 2021

Hey @larissaiurk .

To be really honest I think this package is not being maintained anymore.

Last year I'd merge a PR to solve that and it's indeed missing the release.
Despite the fact I'm set as a contributor, I cannot make releases. I've made a proposal of automating this flow (here #27) but it never got answered.

#23 (comment)

@KesleyDavid
Copy link

Hey, @larissaiurk @raulfdm
I made an update and the necessary adjustments to work correctly in the typescript and made a publication.
I was only using it for my projects, but if you want to use it too

https://www.npmjs.com/package/styled-query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TypeScript] Wrong Type Definition
4 participants