Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Styled Components to 4.0.2, Babel to 7.1.2 #14

Merged
merged 20 commits into from
Dec 16, 2018

Conversation

timhagn
Copy link
Collaborator

@timhagn timhagn commented Oct 23, 2018

First of all, great module, I really like using it with Styled Components!

In preparation for writing the tests with jest, it came to me, that some dependencies were
quite outdated - especially now that styled-components is @ 4.0.2.
So I did the following:

  • updated styled-components ^3.1.5 to ^4.0.2
  • babel-preset-env@^1.6.0 to @babel/core@^7.1.2 & @babel/preset-env@^7.1.0
  • updated rollup ^0.45.2 to ^0.66.6 - and it's plugins accordingly
  • changed rollup.config.js to newest config styles (no warnings with yarn build anymore)
  • removed .babelrc in favor of .babelrc.js

And some smaller changes, as you can see in the commits.

With all this I wanted to:

  1. Bump all to the latest versions
  2. Prepare for writing the tests in jest

I tested the build process and integrated it in a gatsby page with no problems occuring.

This will prepare for:
Tackling Issue #1 - If it's at your convenience.

@morajabi
Copy link
Owner

It looks good! I will try to merge this in later today! Are we sure with peerDep versions? Many people aren't at latest React and might get a little warning from NPM / Yarn cli.

@timhagn
Copy link
Collaborator Author

timhagn commented Oct 26, 2018

Thanks : ). And if they want to use the latest styled-components, they should be, cause there react / react-dom is a dev-Dependency: https://github.com/styled-components/styled-components/blob/master/package.json - so I guess, we are in the clear.

@timhagn timhagn mentioned this pull request Oct 26, 2018
5 tasks
@aureliome
Copy link

Good job @timhagn , I'm waiting this merge with trepidation :)

@timhagn
Copy link
Collaborator Author

timhagn commented Oct 31, 2018

@aureliome Thanks : )! Did you choose the word "trepidation" for Halloween? Cause translated to German it would mean something like "anxiety", "fearfulness" or the like ^^. One never stops learning.
But @morajabi, did you already get the chance to look into merging it (or the tests in #14, for what it's worth)? I'm already using the updated versions in a soon to be production environment with no issues
(putting "styled-media-query": "https://github.com/timhagn/styled-media-query#th-jest-tests" in my package.json for the time being ; ).

@franky47
Copy link
Contributor

I'm really interested in this merge as well ! I'm using styled-components v4 with TypeScript, I'll give this branch a go in the mean time.

Copy link
Collaborator

@ApacheEx ApacheEx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. First of all, you did a great job! Thank you. 🥇

  2. I have a few remarks - hope it's clear, but feel free to discuss 👍

  3. p.s. do we need package-lock.json here? I think yarn.lock is enough. ❓

.babelrc.js Outdated Show resolved Hide resolved
.gitignore Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@morajabi
Copy link
Owner

@timhagn Could you please change the version range like @ApacheEx commented above? Otherwise LGTM :)

@timhagn
Copy link
Collaborator Author

timhagn commented Nov 19, 2018

For all waiting for an answer, my main workstations Motherboard crashed yesterday and I'm just trying to get back on track with my Dev-Laptop -.-
Sorry for the inconvenience, will try to resolve the requested changes as soon as possible % ).

@morajabi
Copy link
Owner

No worries @timhagn! It's open source and we're here to learn and have fun 👋 hope the machine gets alright soon!

@franky47 franky47 mentioned this pull request Nov 21, 2018
5 tasks
@timhagn
Copy link
Collaborator Author

timhagn commented Nov 24, 2018

Although my main workstation is still down:
Finally! Finalmente! Endlich!
Squashed all changes done before into one commit and integrated all your suggestions.
LGTM : )!
(Used my Dev-Laptop ; ).

@ApacheEx
Copy link
Collaborator

ApacheEx commented Nov 26, 2018

I have removed package-lock.json and also unnecessary blank line in .babelrc.json, now it looks good for me. Thank you a lot 🥇

p.s. @morajabi I think it's ready to merge

@morajabi
Copy link
Owner

morajabi commented Nov 26, 2018

@ApacheEx Nice!
@timhagn Thanks a lot for the hard work, I'm excited to merge and release this :D

@timhagn
Copy link
Collaborator Author

timhagn commented Nov 26, 2018

@ApacheEx Thanks for these changes! I'm only irritated a bit about the removal of the "unnecessary blank line, as I added it upon your request ^^.
@morajabi Thanks, was a pleasure : ). As I'm using styled-media-query to ease my life right now, I'd have some ideas on API v3 - but LGTM first ; ).

@timhagn
Copy link
Collaborator Author

timhagn commented Dec 8, 2018

Any updates on this merge? Just asking ; ).

@morajabi morajabi merged commit d44d748 into morajabi:master Dec 16, 2018
@morajabi
Copy link
Owner

First, my apologies for the merging taking so long! It's now published as v2.1.0 🎷
Second, thanks Tim for the PRs, I just invited you to the repository as a collaborator. Although you already have helped with the project, I'd like to have you as a collaborator. This means you can review and manage PRs or issues or even merge PRs when you or the collaborators, or I agree on.

@timhagn
Copy link
Collaborator Author

timhagn commented Dec 16, 2018

Nice! That's greats news on the merge and me now being a contributor. Thanks a lot, gonna use it responsibly : ). And so happy, that I now don't have to integrate my repo in my package.json ^^.

@ApacheEx
Copy link
Collaborator

@morajabi,

I get this error after upgrading, seems github release is missing.
image

@morajabi
Copy link
Owner

@ApacheEx Forgot to push the GH tags, but how does that make the build fail? I thought NPM doesn't depend on these.

@ApacheEx
Copy link
Collaborator

I'm still faced this issue, is it only me?
image

@timhagn
Copy link
Collaborator Author

timhagn commented Dec 17, 2018

Nope, it isn't only you, @ApacheEx, I just tried it and getting the same result -.-
Shouldn't there be a dist folder in the npm package, or how do you finalize the
build process, @morajabi? Hope I didn't break it % ).

@morajabi
Copy link
Owner

Wait, I think I found the cause.

@morajabi
Copy link
Owner

@timhagn @ApacheEx it should be fixed 🙈

@ApacheEx
Copy link
Collaborator

yeah, works now. Thank you guys

@timhagn
Copy link
Collaborator Author

timhagn commented Dec 17, 2018

@morajabi @ApacheEx Yup 2.1.1 is working and has a dist folder ^^. Thanks!
P.S.: What was the problem's source, if you'd indulge, @morajabi?

@morajabi
Copy link
Owner

@timhagn Someone forgot to run yarn build before publishing 😅 (me)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants