Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Netty native transport support on MacOS. #806

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Conversation

jingyu
Copy link
Contributor

@jingyu jingyu commented Jan 8, 2024

Release notes

[rn:skip]

What does this PR do?

  • Add Netty native trsansport support on MacOS. Bundle all the native transport module by default.

Why is it important/What is the impact to the user?

To facilitate development on MacOS, support for the Netty KQueue native transport was added.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the Changelog if it's a feature or a fix that has to be reported

Author's Checklist

  • [ ]

How to test this PR locally

If you enable netty.native in the config file on MacOS, you should see the message "Netty is using KQueue" in the console output when starting the Moquette server.

Related issues

Use cases

@jingyu jingyu marked this pull request as draft January 8, 2024 07:47
@jingyu jingyu marked this pull request as ready for review January 8, 2024 07:49
@MikeDombo
Copy link
Contributor

Longer client IDs are supported when you connect using MQTT v3.1.1 instead of v3.1 or v3. Make sure that your client is connecting with the proper protocol version

@jingyu
Copy link
Contributor Author

jingyu commented Jan 9, 2024

Longer client IDs are supported when you connect using MQTT v3.1.1 instead of v3.1 or v3. Make sure that your client is connecting with the proper protocol version

Yes, both MQTT 3.1.1 and 5.0 can support long client IDs. Therefore, I have reverted the changes related to the clientId and retained only the KQueue support in this PR.

Thank you! @MikeDombo

@jingyu jingyu changed the title Support long client id. Add Netty native transport support on MacOS. Add Netty native transport support on MacOS. Jan 9, 2024
Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adds a line to the Changelog file, then I think we are good to go

broker/pom.xml Outdated Show resolved Hide resolved
Copy link
Collaborator

@andsel andsel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andsel andsel merged commit 6ffb106 into moquette-io:main Mar 22, 2024
@andsel
Copy link
Collaborator

andsel commented Mar 22, 2024

Thanks a lot @jingyu for contributing with this :-) PR merged

@jingyu
Copy link
Contributor Author

jingyu commented Mar 26, 2024

Thanks a lot @jingyu for contributing with this :-) PR merged

My pleasure to contribute to Moquette project :-)

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants