Fix typo in abstract method name (ServerMonitorListener) #997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
While I'd love to merge this, as I hate spelling errors, the problem is that the error is in the spelling of a public method, and fixing it would break binary compatibility with existing applications that are depending on the current, misspelled name. So I'm going to have to close this without merging. But thanks for finding it, and feel free to open PRs for misspellings outside of the public interface of the driver. |
|
@jyemin I know what you mean. thank you 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
open the PR of typo correction too. However, changes have occurred in the abstraction code and the implementation code.
so i open a new PR
--
I understood it to only open issues for features or bugs.
so,,, should i open an issue? if so, please tell me 🙇