Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[locale] bs: Improve relative minute #5748

Closed
wants to merge 1 commit into from

Conversation

rasidre
Copy link
Contributor

@rasidre rasidre commented Oct 5, 2020

This PR is a possible fix for Issue #5512

FYI @frontyard @marwahaha
If this PR is fixing the issue, you can close PR #5713

@rasidre
Copy link
Contributor Author

rasidre commented Oct 5, 2020

@frontyard your definition was almost right. It should be like this:

second
past: prije par sekundi <- correct
future: za par sekundi <- correct

minute:
past: prije jedne minute <- correct
future: za jedne minute <- NOT CORRECT, correct is "za jednu minutu"

hour
past: prije jednog sata <- NOT CORRECT, correct is "prije jedan sat"
future: za jednog sata <- NOT CORRECT, correct is "za jedan sat"

@coveralls
Copy link

coveralls commented Oct 5, 2020

Coverage Status

Coverage increased (+0.01%) to 88.5% when pulling dddcdbb on rasidre:adjust-bs-locale into f5233ee on moment:develop.

@marwahaha
Copy link
Member

@frontyard approval?

@marwahaha
Copy link
Member

@frontyard ?

@marwahaha marwahaha closed this Oct 27, 2020
@marwahaha marwahaha reopened this Oct 27, 2020
@rasidre
Copy link
Contributor Author

rasidre commented Nov 6, 2020

@marwahaha how long will we wait for a locale approvement?

@marwahaha
Copy link
Member

marwahaha commented Nov 6, 2020

I'll give it a few more days. @frontyard can you please approve this?

@rasidre Would you like to be a reviewer? You can add your name to the src/locale file.

@rasidre
Copy link
Contributor Author

rasidre commented Nov 7, 2020

@rasidre Would you like to be a reviewer? You can add your name to the src/locale file.

Of course 🙂 #5772

@ichernev ichernev changed the title [locale] fix translation issue for bs locale [locale] bs: Improve relative minute Dec 25, 2023
@ichernev
Copy link
Contributor

Merged in 443d5de

@ichernev ichernev closed this Dec 26, 2023
ichernev added a commit that referenced this pull request Dec 26, 2023
[locale] bs: Improve relative minute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants