[new locale] ar-ps: Arabic (Palestine) #5190
Closed
+574
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
majdal
changed the title
|
@majdal when adding a new locale you need to put it under |
|
Looks like the prettier check failed. I think you can fix it with |
marwahaha
changed the title
|
Unfortunately, the months are not parsing correctly! This is why the tests are failing. |
marwahaha
reviewed
Jun 17, 2020
| .split('') // reversed since negative lookbehind not supported everywhere | ||
| .reverse() | ||
| .join('') | ||
| .replace(/[١٢](?![\u062a\u0643])/g, function (match) { |
There was a problem hiding this comment.
This is done to avoid parsing the month numbers used in monthsShort.
|
I'll need to change the tests too: we should be using Arabic numerals (1, 2, 3...) instead of the currently defined Indian numerals (١، ٢، ٣...). |
|
Ok @majdal . Let me know how I can assist! |
|
@majdal any updates? |
|
Merged in 794938a |
ichernev
changed the title
ichernev
added a commit
that referenced
this pull request
Dec 23, 2023
[new locale] ar-ps: Arabic (Palestine)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello - Just adding a new local that has Syriac month names, used in Palestine, Lebanon, Syria, Jordan, and Iraq (see).