correct typo in min/max deprecation warnings #3031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, it's intentional. The order is swapped. The docs have it correct, but we used to have the deprecation messages wrong. See #2946, which just went in with 2.12.0. Maybe we could find a better way to phrase it. |
|
Well, it was found while I was writing docs about deprecation warnings, so I'll certainly fit that in. |
|
The old functions, the ones we deprecated, were not intuitive. You'd think The idea with the old ones was a maximum constraint - meaning "return me the value that is no larger than this one". |
|
Well... I'm glad that is deprecated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be better that we suggest people use min to find the min, and max to find the max.