Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added duetone icon #469

Merged
merged 1 commit into from
Aug 1, 2024
Merged

Added duetone icon #469

merged 1 commit into from
Aug 1, 2024

Conversation

Avaray
Copy link
Contributor

@Avaray Avaray commented Jul 21, 2024

Icon is designed to be used on websites. It's TailwindCSS friendly. It's duotone.
I created it because currently, there is no icon that can be used well with TailwindCSS.
The differences between the official Logo and this icon are small, as I didn't want to interfere too much.
Hope this will be useful. I'm waiting for your feedback and thoughts.

In example below I applied some kind of green color.
iconexample

It's designed to be used on website.
Copy link

stackblitz bot commented Jul 21, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

codecov bot commented Jul 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f953ae6) to head (24208d6).

Additional details and impacted files
@@            Coverage Diff            @@
##                v3      #469   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            1         1           
  Lines            1         1           
=========================================
  Hits             1         1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@molefrog
Copy link
Owner

Hi, thank you! Could you prettify or send an uncompressed svg here so I can take a look at the source pls? ☺️

@Avaray
Copy link
Contributor Author

Avaray commented Jul 21, 2024

Hi, thank you! Could you prettify or send an uncompressed svg here so I can take a look at the source pls? ☺️

This one in unoptimized (I dont know if GitHub optimizes it).
icon_duotone

@Avaray
Copy link
Contributor Author

Avaray commented Jul 21, 2024

Hmmmm... Now I think It could be done better. I see that empty space between "nails" and "skin" when image is in big scale.

@molefrog
Copy link
Owner

It's TailwindCSS friendly

I have limited experience with Tailwind, sorry, could you clarify this?

@Avaray
Copy link
Contributor Author

Avaray commented Jul 21, 2024

I have limited experience with Tailwind, sorry, could you clarify this?

In short: it's a very popular library to stylize your websites. I would say it's the most popular library (looking at React world).

When you want to place someone's logo on a website, it's good for it to be scalable (here I'm thinking about the SVG format), and to be able to do something more with it (such as applying a color with CSS).
If the SVG has predetermined colors with zero opacity, overwriting it with CSS style will cause it to be entirely in one color.
Web developers using React typically use icon libraries such as Iconify, while other libraries like TailwindCSS allow them styling icons easily.

Let's say you don't want to apply color. Let's take current logo.svg and put it on website with dark theme. It will be almost invisible, because logo is mostly black. The only option will be to add bright background under logo to keep contrast and make it visible.

The icon I added provides more possibilities.

@molefrog molefrog merged commit 8b5f677 into molefrog:v3 Aug 1, 2024
4 checks passed
@Avaray
Copy link
Contributor Author

Avaray commented Aug 1, 2024

Thanks for adding it. I wish to make this icon better in the future (when I return to playing with vector graphics again).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants