Use ComparableVersion from Maven and remove the duplicate #898
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing the duplicated ComparableVersion, which is also present in Maven.
Because it's removed, I had to rework BoundArtifactVersion a bit. Now it's not "hacking" ComparableVersion anymore, ie, it's no longer using its private implementation to compute compareTo(). Instead, it's construction "infinity-like" version by using Integer.MAX_INT and uses this to do the comparison on the standard DefaultArtifactVersion.
BoundArtifactVersion is also officially, contractually immutable, and because of that, its
parseVersion
method throws an exception and is deprecated.Also, because the ComparableVersion is gone, the cache is also gone, so I've implemented our own, but went a bit further: we're caching DefaultArtifactVersion instead, since it's also (almost) immutable, and we're not using it's only mutating method
parseVersion()
anywhere.On this condition, it's safe to use the cache.