Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #318 includes/excludes for dependencies #602

Merged
merged 1 commit into from
Aug 15, 2022
Merged

Fixes #318 includes/excludes for dependencies #602

merged 1 commit into from
Aug 15, 2022

Conversation

HonoluluHenk
Copy link

@HonoluluHenk HonoluluHenk commented Jun 22, 2022

Fixex #318

@HonoluluHenk HonoluluHenk changed the title Fixes #318 includes/excludes for dependency scopes Fixes #318 includes/excludes for dependencies Jun 27, 2022
@HonoluluHenk
Copy link
Author

@stefanseifert with the last (force-)push, this pr should now be feature-complete, works-on-my-machine (tm) including Unit- and Integration-Tests.

I did not find any guides regarding source-formatting. If you could provide pointers to docs (or preferrably auto-formatters :)), I'd be glad to implement your preferred code style.

@slawekjaranowski
Copy link
Member

https://www.mojohaus.org/development/guidelines.html
https://maven.apache.org/developers/conventions/code.html

@HonoluluHenk
Copy link
Author

I implemented all your review comments, time for another try?

@slawekjaranowski
Copy link
Member

@stefanseifert any remarks for it?

@HonoluluHenk
Copy link
Author

any news on this?
I'd be happy to make further changes...

@slawekjaranowski
Copy link
Member

Pleas squash to final one commit.

fixes #318 implement includes/excludes for dependencies

apply maven codestyle

fixes #318 implement includes/excludes for dependencies

bump @SInCE 2.12.0

fixes #318 implement includes/excludes for dependencies

make ITs work on windows

fixes #318 implement includes/excludes for dependencies

switch to List<String> instead of splitting a list-style string myself

fixes #318 implement includes/excludes for dependencies

migrate ITs to test.properties since maven runner does some magic with "," in invoker.goals with no other workaround
fix some descriptions

fixes #318 implement includes/excludes for dependencies

add IT for multiple comma-separated inclusion filters
@HonoluluHenk
Copy link
Author

...squashed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

versions:display-dependency-updates goal need to have excludes and includes property
2 participants