Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/favicon and loader #2

Merged
merged 2 commits into from
Oct 17, 2021
Merged

Feature/favicon and loader #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81c916d
style: add favicon
mohibkay Oct 17, 2021
219356c
style: add react loader
mohibkay Oct 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added public/images/favicon.ico
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
<html lang="en">
<head>
<meta charset="utf-8" />
<link rel="icon" href="" />
<link rel="icon" href="./images//favicon.ico" />
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta
name="description"
Expand Down
4 changes: 2 additions & 2 deletions src/App.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import { Suspense, lazy } from "react";
import { BrowserRouter as Router, Route, Switch } from "react-router-dom";
import "./App.css";
import Loader from "./components/utils/Loader";
import { ROUTES } from "./constants";
import UserContext from "./context/user";
import useAuthListener from "./customHooks/useAuthListener";
import PrivateRoute from "./components/auth/PrivateRoute";
import Profile from "./pages/profile";
import ReactLoader from "react-loader";

const Login = lazy(() => import("./pages/login"));
const Signup = lazy(() => import("./pages/signup"));
Expand All @@ -19,7 +19,7 @@ function App() {
return (
<UserContext.Provider value={{ user }}>
<Router>
<Suspense fallback={<Loader />}>
<Suspense fallback={<ReactLoader />}>
<Switch>
<Route path={ROUTES.LOGIN} component={Login} />
<Route path={ROUTES.SIGN_UP} component={Signup} />
Expand Down